Skip to content

Added the documentation for the new Asset component #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Added the documentation for the new Asset component #4987

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9e1ac65
Added the documentation for the new Asset component
javiereguiluz Feb 11, 2015
bc3403a
Minor rewording
javiereguiluz Feb 11, 2015
e6e2ba4
Added a missing link reference
javiereguiluz Feb 12, 2015
7312638
Tweaked documentation and added links to API methods/classes
javiereguiluz Feb 15, 2015
ac58089
Fixed a lot of errors and added an introduction
javiereguiluz Feb 16, 2015
9c456e3
Moved the component documentation to its own folder
javiereguiluz Feb 16, 2015
3c83243
Fixed some RST syntax issues
javiereguiluz Feb 16, 2015
6f7a63e
Fixed RST syntax issues
javiereguiluz Feb 19, 2015
6c2b2ee
Lots of fixes and rewordings
javiereguiluz Feb 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor rewording
  • Loading branch information
@javiereguiluz
javiereguiluz committed Feb 11, 2015
commit bc3403a4be0707c87e38c4051a1a3a98b06bdb1d
6 changes: 3 additions & 3 deletions components/asset.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
The Asset Component
===================

The Asset manages URL generation and versioning for web assets such as CSS
stylsheets, JavaScript files and image files.
The Asset component manages URL generation and versioning of web assets such
as CSS stylsheets, JavaScript files and image files.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ("stylsheets")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you!


Installation
------------
Expand Down Expand Up @@ -62,7 +62,7 @@ the application's assets. Asset versions are commonly used to control how these
assets are cached.

Instead of relying on a simple version mechanism, the Asset component allows to
define advanced version strategies via PHP classes. The two built-in strategies
define advanced versioning strategies via PHP classes. The two built-in strategies
provided by the component are ``EmptyVersionStrategy``, which doesn't add any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to use API links here

version to the asset, and ``StaticVersionStrategy``, which allows to set the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the serial comma here

version with a format string.
Expand Down