Skip to content

[Reference] fix code block order #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 8, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

The new documentation standard for the order of code blocks in
validation contraint configurations is Annotations, YAML, XML,
PHP. This commit fixes the order of the configuration examples.

@weaverryan
Copy link
Member

@xabbuh I think the standard is (or should be) annotation before yaml (the validation chapter is like that... but I think I may have just merged a PR that caused this recently). What do do you think?

@xabbuh
Copy link
Member Author

xabbuh commented Mar 14, 2015

You're right, Ryan. We switched the order some time this week and I didn't update here. Will do this when I'm back at my desk. Thanks for noticing.

@wouterj
Copy link
Member

wouterj commented Mar 25, 2015

ping @xabbuh (no rush, just going through the long PR list)

@xabbuh xabbuh force-pushed the validation-code-block-order branch from 2744ecb to 0b17897 Compare April 13, 2015 18:28
The new documentation standard for the order of code blocks in
validation contraint configurations is *Annotations*, *YAML*, *XML*,
*PHP*. This commit fixes the order of the configuration examples.
@xabbuh
Copy link
Member Author

xabbuh commented Apr 13, 2015

I changed the order of all validation related configuration blocks to respect the new order.

@weaverryan
Copy link
Member

Thanks Christian! Big and nice work :)

@weaverryan weaverryan merged commit 4592564 into symfony:2.3 Apr 15, 2015
weaverryan added a commit that referenced this pull request Apr 15, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

[Reference] fix code block order

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

The new documentation standard for the order of code blocks in
validation contraint configurations is *Annotations*, *YAML*, *XML*,
*PHP*. This commit fixes the order of the configuration examples.

Commits
-------

4592564 fix code block order
@xabbuh xabbuh deleted the validation-code-block-order branch April 15, 2015 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants