[Form] Replaced "form_widget" by "form_row" in collection example #5133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2015
|
I think we do want it without the label. You just have a list of inputs, having the label repeated for each option seems not so great to me. What do others think about this? /cc @xabbuh @webmozart |
|
Imho we should keep the reference as is, but reference the cookbook section that explains how to customise this in #4629. What do you think? |
|
Hey @romaricdrigon! I agree with keeping things as-is. For the other fields, we're only rendering the errors and widget, so it makes sense to only add the widget (and as Wouter said, we don't really want multiple labels). You could do it either way, but I think we should keep this. It's also consistent with the way that customizing the prototype is described in #5643. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In the Form reference documentation, for the
collectionfield, an example is given about rendering the prototype.But
form_widgetTwig function is used instead ofform_row. This is a bad advice in my opinion, as rendered HTML is then different than the one for an already here field. In example, we will be missing the label.The small fix change the function used.