-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Updated Cookies & Caching section #5188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Updated Cookies & Caching section
Correct code for Varnish 4 (unset instead of remove)
- Loading branch information
commit 59a27de1e0e5d8d7a5aedd67b04ea81fade9063a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,7 +76,9 @@ session cookie, if there is one, and get rid of all other cookies so that pages | |
are cached if there is no active session. Unless you changed the default | ||
configuration of PHP, your session cookie has the name ``PHPSESSID``: | ||
|
||
.. code-block:: varnish4 | ||
.. configuration-block:: | ||
|
||
.. code-block:: varnish4 | ||
|
||
sub vcl_recv { | ||
// Remove all cookies except the session ID. | ||
|
@@ -89,11 +91,30 @@ configuration of PHP, your session cookie has the name ``PHPSESSID``: | |
|
||
if (req.http.Cookie == "") { | ||
// If there are no more cookies, remove the header to get page cached. | ||
remove req.http.Cookie; | ||
unset req.http.Cookie; | ||
} | ||
} | ||
} | ||
|
||
.. code-block:: varnish3 | ||
|
||
sub vcl_recv { | ||
// Remove all cookies except the session ID. | ||
if (req.http.Cookie) { | ||
set req.http.Cookie = ";" + req.http.Cookie; | ||
set req.http.Cookie = regsuball(req.http.Cookie, "; +", ";"); | ||
set req.http.Cookie = regsuball(req.http.Cookie, ";(PHPSESSID)=", "; \1="); | ||
set req.http.Cookie = regsuball(req.http.Cookie, ";[^ ][^;]*", ""); | ||
set req.http.Cookie = regsuball(req.http.Cookie, "^[; ]+|[; ]+$", ""); | ||
|
||
if (req.http.Cookie == "") { | ||
// If there are no more cookies, remove the header to get page cached. | ||
remove req.http.Cookie; | ||
} | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This blank line should be removed. |
||
|
||
.. tip:: | ||
|
||
If content is not different for every user, but depends on the roles of a | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code block itself now needs to be indented by four spaces.