Skip to content

Tweaks to bower entry - specifically committing deps #5294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2015
+30 −1
Merged

Tweaks to bower entry - specifically committing deps #5294

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d526765
Small tweaks, but mostly adding a section about committing Bower assets
weaverryan May 23, 2015
7f4b55e
Many tweaks thanks to the team!
weaverryan May 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Many tweaks thanks to the team!
  • Loading branch information
@weaverryan
weaverryan committed May 23, 2015
commit 7f4b55ed09fbefd846e792d8d5d14b16e901b873
12 changes: 6 additions & 6 deletions cookbook/frontend/bower.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ then run:

$ npm install -g bower

After this command finishes, run ``bower`` in your terminal to find out if
After this command has finished, run ``bower`` in your terminal to find out if
it's installed correctly.

.. tip::
Expand All @@ -45,7 +45,7 @@ create a ``.bowerrc`` file with a new destination (like ``web/assets/vendor``):

.. tip::

If you're using a frontend build system like `Gulp`_ or `Grunt`_, then
If you're using a front-end build system like `Gulp`_ or `Grunt`_, then
you can set the directory to whatever you want. Typically, you'll use
these tools to ultimately move all assets into the ``web/`` directory.

Expand Down Expand Up @@ -125,15 +125,15 @@ file:

.. code-block:: bash

git add web/assets/vendor
$ git add web/assets/vendor

Why? Unlike Composer, Bower currently does not have a "lock" feature, which
means that there's no guarantee that running ``bower install`` on a different
server will give you the *exact* assets that you have on other machines.
For more details, read the article `Checking in fronte-end dependencies`_.
For more details, read the article `Checking in front-end dependencies`_.

But, it's very possible that Bower will add a lock feature in the future
(e.g. `bower/bower#1748`_)
(e.g. `bower/bower#1748`_).

.. _Bower: http://bower.io
.. _`Node.js`: https://nodejs.org
Expand All @@ -142,5 +142,5 @@ But, it's very possible that Bower will add a lock feature in the future
.. _Bootstrap: http://getbootstrap.com/
.. _Gulp: http://gulpjs.com/
.. _Grunt: http://gruntjs.com/
.. _`Checking in fronte-end dependencies`: http://addyosmani.com/blog/checking-in-front-end-dependencies/
.. _`Checking in front-end dependencies`: http://addyosmani.com/blog/checking-in-front-end-dependencies/
.. _`bower/bower#1748`: https://github.com/bower/bower/pull/1748