Skip to content

Added a note about Symfony Validator use outside framework context #5563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mickaelandrieu
Copy link
Contributor

Hi,

I think there is a lot more to say (Translating, object initializers, describe all mappings methods), maybe can we create docs for Validator component ?

What do you think @lyrixx ?

@javiereguiluz
Copy link
Member

There is a 3.5 years old issue about this (#958) but it seems nobody is willing to work on it.

@mickaelandrieu
Copy link
Contributor Author

@javiereguiluz I think I can do it.

@mickaelandrieu mickaelandrieu changed the title Added a note about Symfony Validator use Added a note about Symfony Validator use outside framework context Jul 27, 2015
@stof
Copy link
Member

stof commented Jul 27, 2015

There is an initial work done in #3710 but abandoned. You might want to start from it rather than starting from scratch

@mickaelandrieu
Copy link
Contributor Author

thank you @stof

So:

  • add a note to the actual documentation that will (probably) link to a new "Validator" section in components documentation;
  • Create a new section "Validator" starting from @wouterj old pull request;

does it sound good to you ?

@stof
Copy link
Member

stof commented Jul 27, 2015

This section should not be in the book at all IMO. the book is talking about the fullstack framework. It is not talking about standalone usage (this is what the component documentation is about).

So I'm not sure this PR is a good idea actually (but the decision is not mine as I'm not one of the documentation maintainers). However, creating the validator component documentation is a very good idea (it is the only missing component)

@wouterj
Copy link
Member

wouterj commented Jul 27, 2015

@mickaelandrieu thank you for starting over and good luck! I propose to do the following (which is also what I wanted to do):

  • Create a new Validator section in the Components docs
  • (components) Document how to set up the validator in a standalone
  • (components) Move the current book chapter to a usage chapter in the components
  • (components) Move everything that's about framework specific things (like registering constraint validator by tagging them) back to a new book chapter and rewrite things so it's a smooth read again
  • (book) Reread and tweak the new book chapter, so people don't get a too disoriented feeling, switching from book to components each time.

You can take the current translation docs as an example. If you have questions, need help, etc, feel free to leave a comment or ask for help in #symfony-docs on IRC.

@mickaelandrieu
Copy link
Contributor Author

Hi @wouterj : ok, I will do that.

I need time ... probably make a pull request the next week. Thank you for your help!

@wouterj
Copy link
Member

wouterj commented Feb 6, 2016

I'm going to close this PR in favor of documenting the component.

@wouterj wouterj closed this Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants