Skip to content

Fixed image/document not being displayed because of the __DIR__ option in the path. #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tristanbes
Copy link
Contributor

Added another method in order to prevent the document/image not being displayed because of the rendered path with DIR. I tryed to make it as clean as possible.

… displayed because of the rendered path with DIR. I tryed to make it as clean as possible.
@stof
Copy link
Member

stof commented Jul 18, 2011

Instead of creating a different pull request each time yo want to fix something, just commit in the same branch :)

protected function getRealLocation()
{
// get rid of the __DIR__ so it doesn't screw when displaying uploaded doc/image in the view.
return '/uploads/documents';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not add the leading slash here otherwise the rendered link when using asset() in a template will always be /uploads/... even when your app is not at the root of the domain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof yeah but having the app at the top of the domain and not using a leading slash result in the image not rendering. Where this leading slash should be added so ? in the template ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said on the previous PR, you need to use the asset() function in your template to make your app portable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks, just pushed the modifications. I've just tested and you are right using asset() automatically adds the missing leading slash when it's needed.

@tristanbes
Copy link
Contributor Author

Sry for the differents pull request. I'm definitly not familiar with the web interface when editing & submitting a pull request.

@tristanbes tristanbes closed this Jul 18, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants