Add mention for Bower.json #5778
Conversation
|
The issue is that bower does not have a lock file currently, which means you would have no guarantee about what will get installed by other devs or during deployment. |
|
I agree on that (in a way). I'm not arguing the method or best practice but i think it should be mentioned that this is also a possible option next to the option of adding or ignoring the bower folder in git. |
|
If we added such a sentence it should not get it's section (so we don't implicitly state that this option is of the same values as the one already described), but we could get a note explaining the consequences of choosing this solution (i.e. using control about the exact versions being installed). However, I am not really convinced we should do that at all. |
This PR was merged into the 2.3 branch. Discussion ---------- Mention commiting only bower.json Replaces #5778 | Q | A | --- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | - The section is called "Should I Git Ignore or Commit Bower Assets?", but we cover only the commit way and not the git ignore way, giving users a bit biased information. We should at least mention that people can also commit bower.json. Thanks to @KriKe for providing the original patch! Commits ------- d701e3d Rewrite section about bower.json 1a98bca Add mention for Bower.json
Like you would never commit the vendor folder, neither should you commit the Bower folder. At least bower.json should be mentioned. I would think it to be logic to commit the generate build files (/dist or /public) but not the dependencies.