Skip to content

Conversation

dlsniper
Copy link
Contributor

Added reference to Doctrine manual regarding reserved SQL keywords escaping.

@@ -1296,3 +1301,4 @@ For more information about Doctrine, see the *Doctrine* section of the
.. _`Mapping Types Documentation`: http://www.doctrine-project.org/docs/orm/2.0/en/reference/basic-mapping.html#doctrine-mapping-types
.. _`Property Mapping documentation`: http://www.doctrine-project.org/docs/orm/2.0/en/reference/basic-mapping.html#property-mapping
.. _`Lifecycle Events documentation`: http://www.doctrine-project.org/docs/orm/2.0/en/reference/events.html#lifecycle-events
.. _`Reserved SQL keywords documentation`: http://www.doctrine-project.org/docs/orm/2.0/en/reference/basic-mapping.html#quoting-reserved-words
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is not used in the chapter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should I use the link? I'm very new to the documentation format and @work the same time. Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use ``Reserved SQL keywords documentation_ somewhere in the file to place the link.
See line 27 (that appear in the diff here) for the link to MongoDB for instance

weaverryan added a commit that referenced this pull request Jul 27, 2011
Added reference to Doctrine manual regarding reserved SQL keywords
@weaverryan weaverryan merged commit 6724fe7 into symfony:master Jul 27, 2011
@weaverryan
Copy link
Member

Thanks - merged but moved down to the area where the actual mapping takes place: 770127b

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants