Document typed arrays in optionsresolver #6048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| Because the OptionsResolver will validate typed arrays recurively, it is possible to |
There was a problem hiding this comment.
- recurively
+ recursively| public function configureOptions(OptionsResolver $resolver) | ||
| { | ||
| // ... | ||
| //allowed type is a 2D array of string values |
There was a problem hiding this comment.
would add a space between // and allowed
|
Hi @EVODelavega! Congratz on your feature! As you submitted this doc PR 2 years ago, I've finished it for you in #8946 . I've kept your commit, so that you'll still get the credits you deserve. Thanks for starting this PR and creatign this great feature! |
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2018
…VODelavega, wouterj) This PR was merged into the 3.4 branch. Discussion ---------- [OptionsResolver] Documented validation of array types This continues #6048 . The feature was finally merged into symfony 3.4 (congratz @EVODelavega!), so let's document it! Related Symfony PR: symfony/symfony#17032 Commits ------- cb12592 Merged new example in older example, removing some text 318e199 Fix typo bf5d9d3 Document typed arrays in optionsresolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for changes introduced by Symfony PR 17032