Added comment about SVG height property #6128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nyholm thanks for this contribution. However, I'd consider this a web profiler bug. In the toolbar the height/width is limited to 24px. So I don't understand why it looks bad in the toolbar. Meanwhile, the profiler menu doesn't limit the height of the icons, so that's the main bug in my opinion. |
|
Yeah, I agree it is a bug. It has been there for a good while (before the redesign). Do you think I should close this PR and open an issue at WebProfiler repo instead? |
|
Yes, I think that opening an issue to fix the underlying bug is the way to go here. Thanks! |
|
We can close this issue because it's been reported in the code repo (symfony/symfony#17329) and a solution has already been provided (symfony/symfony#17330). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use a .svg file for the toolbar icon it must have
height="24"or the toolbar will render strangely. The attached images will show an example of this render error.