Skip to content

use valid XML in code block #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2016
Merged

use valid XML in code block #6183

merged 1 commit into from
Jan 27, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jan 25, 2016

No description provided.

@xabbuh
Copy link
Member Author

xabbuh commented Jan 25, 2016

Looks like this is related to a recent update of Sphinx on Travis. 1.3.4 didn't fail with this while 1.3.5 now does.

@wouterj
Copy link
Member

wouterj commented Jan 25, 2016

unfortunately, it still breaks.

@xabbuh xabbuh force-pushed the fix-build branch 4 times, most recently from fda7eec to bf1712d Compare January 25, 2016 16:36
@wouterj
Copy link
Member

wouterj commented Jan 25, 2016

@xabbuh since 1.3.5, pygments errors are now triggered as warnings in Sphinx (sphinx-doc/sphinx@0329edc). Pygments always had an issue rendering this code blocks, it seems.

The problem is the & char, which has to be &: http://pygments.org/demo/3557987/

@xabbuh
Copy link
Member Author

xabbuh commented Jan 25, 2016

Yeah, there are some more issues in other files. I'll fix them and make a big update here.

@xabbuh xabbuh merged commit 674becd into 2.3 Jan 27, 2016
xabbuh added a commit that referenced this pull request Jan 27, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

use valid XML in code block

Commits
-------

674becd use valid XML in code block
@xabbuh xabbuh deleted the fix-build branch January 27, 2016 18:31
@@ -162,7 +162,7 @@ Because MongoDB uses dynamic collection schemas, you do not need to do anything
session collection. However, you may want to add an index to improve garbage collection performance.
From the `MongoDB shell`_:

.. code-block:: sql
.. code-block:: text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's weird, SQL should be available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, it isn't sql.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it's shell code, shouldn't we use bash + $ though?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It even isn't shell code, is it? I mean it's the MongoDB shell, but I am not sure if the bash highligher will handle that properly. Let's try it (see #6192).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants