-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
use valid XML in code block #6183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this is related to a recent update of Sphinx on Travis. 1.3.4 didn't fail with this while 1.3.5 now does. |
unfortunately, it still breaks. |
fda7eec
to
bf1712d
Compare
@xabbuh since 1.3.5, pygments errors are now triggered as warnings in Sphinx (sphinx-doc/sphinx@0329edc). Pygments always had an issue rendering this code blocks, it seems. The problem is the |
Yeah, there are some more issues in other files. I'll fix them and make a big update here. |
This PR was merged into the 2.3 branch. Discussion ---------- use valid XML in code block Commits ------- 674becd use valid XML in code block
@@ -162,7 +162,7 @@ Because MongoDB uses dynamic collection schemas, you do not need to do anything | |||
session collection. However, you may want to add an index to improve garbage collection performance. | |||
From the `MongoDB shell`_: | |||
|
|||
.. code-block:: sql | |||
.. code-block:: text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's weird, SQL should be available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad, it isn't sql.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as it's shell code, shouldn't we use bash + $
though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It even isn't shell code, is it? I mean it's the MongoDB shell, but I am not sure if the bash highligher will handle that properly. Let's try it (see #6192).
No description provided.