Skip to content

[Intl] Document timezone support #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

c960657
Copy link

@c960657 c960657 commented Feb 1, 2016

Q A
Doc fix? no
New docs? yes (symfony/symfony#17636)
Applies to 3.0+
Fixed tickets N/A

@wouterj
Copy link
Member

wouterj commented Feb 6, 2016

👍

After your code PR has been merged, a .. versionadded:: 3.1 directive should be added indicating this function was introduced in Symfony 3.1 (or whatever version it'll be merged in).


\Locale::setDefault('en');

$locales = Intl::getTimezoneBundle()->getTimezoneNames();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$locales variable doesn't store locales but time zone names. Same few lines below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -335,6 +335,27 @@ to the current default locale::
$currencies = Intl::getCurrencyBundle()->getCurrencyNames('de');
// => array('AFN' => 'Afghanische Afghani', ...)

Timezones
~~~~~~~~~

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version added ?

@xabbuh xabbuh added this to the 3.2 milestone May 21, 2016
@wouterj wouterj removed this from the 3.2 milestone Nov 8, 2016
@xabbuh xabbuh added this to the 3.3 milestone Dec 30, 2016
@c960657
Copy link
Author

c960657 commented Jul 13, 2017

Closing because symfony/symfony#17636 was rejected.

@c960657 c960657 closed this Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants