Skip to content

Added minor clarification #6336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added minor clarification #6336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added minor clarification 
It was not clear if the following code applies to BinaryFileResponse only or to all file responses.

Since the following two paragraphs ("It is possible to delete ..." and "If you just created...") also apply to BinaryFileResponse only, it would be even better to have a separate heading for BinaryFileResponse, but I don't know how to create another sub-heading at this level.
  • Loading branch information
@ThomasLandauer
ThomasLandauer committed Mar 6, 2016
commit 76c795bd4868a28cac26c1b33c3cbeed35a8fdab
3 changes: 2 additions & 1 deletion components/http_foundation/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,8 @@ if it should::

BinaryFileResponse::trustXSendfileTypeHeader();

You can still set the ``Content-Type`` of the sent file, or change its ``Content-Disposition``::
With the ``BinaryFileResponse``, you can still set the ``Content-Type`` of the sent file,
or change its ``Content-Disposition``::

$response->headers->set('Content-Type', 'text/plain');
$response->setContentDisposition(
Expand Down