Skip to content

[book] controller ch review, part 2 #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2016
Merged

[book] controller ch review, part 2 #6351

merged 2 commits into from
Mar 17, 2016

Conversation

talitakz
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets no

I moved subtitle "The Request as a Controller Argument" a little bit further down; since it is dealing with the Request object i think it fits with the subtitle "Managing the Session" since this also deals with the Request object.

@talitakz talitakz changed the title controller ch review, part 2 [book] controller ch review, part 2 Mar 11, 2016
@weaverryan weaverryan merged commit fdb7bc9 into symfony:2.3 Mar 17, 2016
weaverryan added a commit that referenced this pull request Mar 17, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

[book] controller ch review, part 2

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | no

I moved subtitle "The ``Request`` as a Controller Argument" a little bit further down; since it is dealing with the ``Request`` object i think it fits with the subtitle "Managing the Session" since this also deals with the ``Request`` object.

Commits
-------

fdb7bc9 typo
b56bf19 controller ch review, part 2
To serve HTML, template needs to be rendered and the content put into
the ``Response`` object. The shortcut method
:method:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller::render`
of ``Controller`` class does just that::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like a lot of the ways you re-phrased things, but not this one :). I'm reverting back to the original, which I still think is quite clear.

weaverryan added a commit that referenced this pull request Mar 17, 2016
Making minor tweaks after reading through the changes in those PR's
weaverryan added a commit that referenced this pull request Mar 17, 2016
* 2.3: (24 commits)
  [#6365] Removing extra :
  Added minor clarification
  [#6360] Minor changes
  [#6349][#6351][#6352]
  Editing the Doctrine section to improve readability.
  Minor corrections
  Fixed typo
  Fix escaping of backtick inside double back-quotes
  Removed server:stop code block for 2.3
  Removed the PR table example (this is now included by GitHub template)
  Updated link to Translatable Extension
  [reference] [constraints] added missing colon character for Image constraint documentation in YAML format.
  Editing the Doctrine section to improve readability.
  Removed info about reducing visibility for private
  Updated link to Translatable Extension
  Editing the Doctrine section to improve readability.
  typo
  controller ch review, part 3
  typo
  controller ch review, part 2
  ...
@talitakz talitakz deleted the book-controller2 branch March 18, 2016 10:26
xabbuh added a commit that referenced this pull request Mar 26, 2016
* 2.7: (32 commits)
  Fixed wrong code examples for Isbn constraint
  unused use instructions
  Fix typo in SwitchUserListener file name
  Changed folder name to lowercase (best practises)
  [#6365] Removing extra :
  Add a note about enabling DebugBundle to use VarDumper inside Symfony
  Update introduction.rst
  Added minor clarification
  Changed folder name to lowercase (best practises)
  Fixed typo in path
  [#6360] Minor changes
  [#6349][#6351][#6352]
  Editing the Doctrine section to improve readability.
  Minor corrections
  Fixed typo
  Fix escaping of backtick inside double back-quotes
  Removed server:stop code block for 2.3
  Removed the PR table example (this is now included by GitHub template)
  Updated link to Translatable Extension
  [reference] [constraints] added missing colon character for Image constraint documentation in YAML format.
  ...

Conflicts:
	book/controller.rst
xabbuh added a commit that referenced this pull request Mar 26, 2016
* 2.8: (37 commits)
  Fixed wrong code examples for Isbn constraint
  Calling the parent implementation is mandatory.
  unused use instructions
  Fix typo in SwitchUserListener file name
  Reworded the example about $deep param
  Changed folder name to lowercase (best practises)
  [#6365] Removing extra :
  Add a note about enabling DebugBundle to use VarDumper inside Symfony
  Update introduction.rst
  Added minor clarification
  Changed folder name to lowercase (best practises)
  Fixed typo in path
  [#6360] Minor changes
  [#6349][#6351][#6352]
  Update "bootstrap.php.cache" to "autoload.php"
  Editing the Doctrine section to improve readability.
  Minor corrections
  Fixed typo
  Fix escaping of backtick inside double back-quotes
  Made list of types more consistent
  ...

Conflicts:
	book/installation.rst
	book/testing.rst
xabbuh added a commit that referenced this pull request Mar 26, 2016
* 3.0: (38 commits)
  Fixed wrong code examples for Isbn constraint
  Calling the parent implementation is mandatory.
  unused use instructions
  Fix typo in SwitchUserListener file name
  Reworded the example about $deep param
  Changed folder name to lowercase (best practises)
  [#6365] Removing extra :
  Add a note about enabling DebugBundle to use VarDumper inside Symfony
  Update introduction.rst
  Added minor clarification
  Changed folder name to lowercase (best practises)
  Fixed typo in path
  [#6360] Minor changes
  [#6349][#6351][#6352]
  Update "bootstrap.php.cache" to "autoload.php"
  Editing the Doctrine section to improve readability.
  Minor corrections
  Fixed typo
  Fix escaping of backtick inside double back-quotes
  Made list of types more consistent
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants