Added docs for file helper #6454
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dfridrich
commented
Apr 10, 2016
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes symfony/symfony#18502 |
| Applies to | 3.1 |
| Fixed tickets |
|
LGTM 👍 |
|
@OskarStark it can't be as the feature has not yet been merged (and there still is some discussion on the implementation). |
|
Oh sorry @wouterj , i meant the current status looks good ;-) |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jun 15, 2016
…rich) This PR was squashed before being merged into the 3.2-dev branch (closes #18502). Discussion ---------- [FrameworkBundle] Add file helper to Controller | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#6454 I think it would be more "sexy" to serve files from controller easier (like `json()` helper does). **This Controller helper allows user to serve files to Response in these ways:** * pass `Symfony\Component\HttpFoundation\File` (or `Symfony\Component\HttpFoundation\UploadedFile`) instance * [REMOVED] provide content as `string` and specify file name (mime type will be auto recognized) * provide path to file (you are still able to specify other than original file name) **Examples** return $this->file($uploadedFile); // ...or... return $this->file('/path/to/my/picture.jpg'); Commits ------- d9a8499 [FrameworkBundle] Add file helper to Controller
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jun 15, 2016
…rich) This PR was squashed before being merged into the 3.2-dev branch (closes #18502). Discussion ---------- [FrameworkBundle] Add file helper to Controller | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#6454 I think it would be more "sexy" to serve files from controller easier (like `json()` helper does). **This Controller helper allows user to serve files to Response in these ways:** * pass `Symfony\Component\HttpFoundation\File` (or `Symfony\Component\HttpFoundation\UploadedFile`) instance * [REMOVED] provide content as `string` and specify file name (mime type will be auto recognized) * provide path to file (you are still able to specify other than original file name) **Examples** return $this->file($uploadedFile); // ...or... return $this->file('/path/to/my/picture.jpg'); Commits ------- d9a8499 [FrameworkBundle] Add file helper to Controller
| File helper | ||
| ~~~~~~~~~~~ | ||
|
|
||
| If you want to serve file use |
|
Hi @dfridrich. I've rebased your PR and tweaked the wording a bit (so we can remove most of the paragraph and use the code examples more) in #6732. I've kept your commit, so you'll still get the credits you deserve. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.