-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
yaml quotes around _controller value #6604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Did you experience an issue with the existing config? A colon in an unquoted mapping should only be an issue if it is followed by a space. |
@kasparsklavins I think that using colons inside an unquoted mapping value is still valid. I can't find any reference to this deprecation. Do you have some link with more information? Thanks! |
Didnt have problems with it, IDE didnt like it. It's a bug in https://github.com/Haehnchen/idea-php-symfony2-plugin then. |
@xabbuh thanks for the link and sorry about the confusion. @kasparsklavins you are right about this deprecation ... but it doesn't affect you in this case: defaults:
# deprecated
_controller: FrameworkBundle: Redirect:urlRedirect
# not deprecated
_controller: FrameworkBundle:Redirect:urlRedirect
# quotes solve all problems
_controller: 'FrameworkBundle:Redirect:urlRedirect'
_controller: 'FrameworkBundle: Redirect:urlRedirect' I'm glad this was just an issue with the Symfony plugin then :) |
@kasparsklavins You are right. I checked the plugin's intentions and proposed a fix for this (see Haehnchen/idea-php-symfony2-plugin#733). |
@xabbuh thx nice try, but lexer provides different result then, fixed :) |
@Haehnchen Thanks for doing it the right way. :) |
Using a colon in the unquoted mapping value is deprecated since Symfony 2.8.