[Console] Fix wrong quotes in QuestionHelper::setInputStream() #6644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 @chalasr nice catch and a quick win. Thanks! |
|
Status: Reviewed |
xabbuh
added a commit
that referenced
this pull request
Jun 11, 2016
…eam() (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [Console] Fix wrong quotes in QuestionHelper::setInputStream() As pointed by [this Stack Overflow question](http://stackoverflow.com/questions/37709966/symfony-interactive-command-test-ends-with-runtimeexception/37712073), the code example showing how to test a command that interacts with the user is wrong. The reason is that `\n` between simple quotes are [not considered as break lines](http://stackoverflow.com/questions/2531969/print-newline-in-php-in-single-quotes) in PHP, even escaped with an additional `\`. Commits ------- 5679e2d Fix wrong quotes in QuestionHelper::setInputStream()
|
Thank you @chalasr for fixing an issue you noticed while helping someone on StackOverflow. This is how a great community works. 🎉 |
|
@javiereguiluz @xabbuh Thank you for consider it, always a pleasure to participate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed by this Stack Overflow question, the code example showing how to test a command that interacts with the user is wrong.
The reason is that
\nbetween simple quotes are not considered as break lines in PHP, even escaped with an additional\.