Skip to content

Minor rewording for the security:checker article #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

javiereguiluz
Copy link
Member

Installing the bundle is not enough ... you must enable it also.

@javiereguiluz javiereguiluz changed the base branch from 2.8 to 2.7 September 1, 2016 13:40
@javiereguiluz javiereguiluz changed the base branch from 2.7 to 2.8 September 1, 2016 13:40
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "is installed and enabled in your application" and keeping the composer require command?

@javiereguiluz
Copy link
Member Author

@wouterj I don't like the idea of showing the composer command because I don't want to duplicate this kind of installation instructions. But if others agree with you, I'll do the changes. Meanwhile I did the other changes that you suggested. Thanks.

@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

To me this sounds fine. Someone not using the Standard Edition (which has the SensioDistributionBundle enabled by default) will probably have no problem in finding out how to install a package using Composer.

Status: Reviewed

@javiereguiluz javiereguiluz force-pushed the improve_security_checker branch from 52bfff5 to 56bdf43 Compare September 28, 2016 10:07
@xabbuh
Copy link
Member

xabbuh commented Dec 12, 2016

Thank you Javier.

xabbuh added a commit that referenced this pull request Dec 12, 2016
…guiluz)

This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #6940).

Discussion
----------

Minor rewording for the security:checker article

Installing the bundle is not enough ... you must enable it also.

Commits
-------

84fabcc Minor rewording for the security:checker article
@xabbuh xabbuh closed this Dec 12, 2016
@javiereguiluz javiereguiluz deleted the improve_security_checker branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants