Yaml: Removed boolean flags #6950
Conversation
|
|
||
| // throw an exception if an encoded object is found in the YAML string | ||
| Yaml::parse($yaml, true); | ||
| Yaml::parse($yaml, Yaml::PARSE_EXCEPTION_ON_INVALID_TYPE); | ||
|
|
||
| However, you can activate object support using the next argument:: |
There was a problem hiding this comment.
this is no longer true, it's not the next statement. Can you please rewrite this sentence?
|
Thanks for catching this and fixing it! I've left one minor comment. If you can fix it, it would be great. Otherwise, we'll do it while merging. Status: needs work |
|
For the records: This will fix parts (everything?) of #6226. |
No worries, you're doing a perfect job! :) |
| @@ -214,6 +228,42 @@ changed using the third argument as follows:: | |||
| foo: bar | |||
| bar: baz | |||
|
|
|||
| Mulit-line strings as scalar blocks | |||
|
@chr-hertel I left some minor comments but your pull request is great! Thank you. 👍 Status: reviewed |
|
thanks @javiereguiluz, i fixed that. |
|
@chr-hertel Sorry for the late feedback: It looks like we covered parts of this with #6622. Can you rebase here and resolve the conflicts? Status: Needs work |
|
Hello @chr-hertel do you still have time to work on this or do you want us to finish it? Thanks! |
|
i guess this one is not longer needed. |
Remove deprecated boolean flags and use const instead.