Skip to content

Documented the Lockable Trait #6953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Documented the Lockable Trait #6953

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

This fixes #6678

@xabbuh
Copy link
Member

xabbuh commented Sep 21, 2016

Do we really need the first code example? Why not simply document only the second one?

@javiereguiluz
Copy link
Member Author

@xabbuh I agree with you. Removed the first example.

@xabbuh
Copy link
Member

xabbuh commented Sep 28, 2016

👍

Status: Reviewed

@xabbuh xabbuh closed this in 0e7abbb Nov 5, 2016
xabbuh added a commit that referenced this pull request Nov 5, 2016
@xabbuh
[#6953] add versionadded directive
50469f2
@xabbuh
Copy link
Member

xabbuh commented Nov 5, 2016

Thank you Javier. I have merged this in and added a versionadded directive in 50469f2.

@javiereguiluz javiereguiluz deleted the fix_6678 branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the LockableTrait
3 participants
@javiereguiluz @xabbuh @carsonbot