Skip to content

[Serializer] versionadded directive for name_converter option #6992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2016

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 21, 2016

No description provided.

name_converter
..............

**type**: ``string``

.. versionadded:: 2.8
The ``name_converter`` setting was introduced in Symfony 2.8.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xxx setting was introduced ... is used 3 times in Symfony Docs, but The xxx option was introduced... alternative is used tens of times. Let's normalize that in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #7007

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wouterj
Copy link
Member

wouterj commented Sep 23, 2016

No brainer 👍

status: reviewed

@xabbuh xabbuh merged commit 469d611 into symfony:2.8 Sep 24, 2016
xabbuh added a commit that referenced this pull request Sep 24, 2016
…tion (xabbuh)

This PR was merged into the 2.8 branch.

Discussion
----------

[Serializer] versionadded directive for name_converter option

Commits
-------

469d611 versionadded directive for name_converter option
@xabbuh xabbuh deleted the name-converter-versionadded branch September 24, 2016 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants