[DomCrawler] Document XPath expression evaluation #7033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Oct 4, 2016
|
|
||
| The ``evaluate()`` method evaluates the given XPath expression. | ||
| The return value depends if the expression operates on simple values | ||
| (like html attributes), or returns a subset of the current document. |
There was a problem hiding this comment.
html attributes -> HTML attributes
mickaelandrieu
approved these changes
Oct 6, 2016
xabbuh
reviewed
Oct 7, 2016
| @@ -282,6 +282,60 @@ and :phpclass:`DOMNode` objects: | |||
|
|
|||
| $html = $crawler->html(); | |||
|
|
|||
| Expression evaluation | |||
xabbuh
reviewed
Oct 7, 2016
| ~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The ``evaluate()`` method evaluates the given XPath expression. | ||
| The return value depends if the expression operates on simple values |
wouterj
reviewed
Nov 9, 2016
|
|
||
| The ``evaluate()`` method evaluates the given XPath expression. | ||
| The return value depends on if the expression operates on simple values | ||
| (like HTML attributes), or returns a subset of the current document. |
There was a problem hiding this comment.
"[...] if the expression operates on simple values (like HTML attributes) or a subset of the current document." ?
|
|
||
| This behavior is best illustrated with examples: | ||
|
|
||
| .. code-block:: php |
There was a problem hiding this comment.
please transform these 3 lines to This behaviour is best illustrated with examples::
|
👍 |
wouterj
added a commit
that referenced
this pull request
Nov 10, 2016
This PR was merged into the master branch. Discussion ---------- [DomCrawler] Document XPath expression evaluation Documents symfony/symfony#19430 Commits ------- 156b047 [DomCrawler] Document XPath expression evaluation
wouterj
added a commit
that referenced
this pull request
Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents symfony/symfony#19430