Skip to content

Added an article about private console commands #7052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

javiereguiluz
Copy link
Member

This documents symfony/symfony#20029.

@xabbuh
Copy link
Member

xabbuh commented Oct 22, 2016

In symfony/symfony#20266 we renamed the attribute from $private to $hidden and inversed its meaning. We need to reflect that here.

Status: Needs work

@wouterj wouterj added this to the 3.2 milestone Nov 9, 2016
@wouterj
Copy link
Member

wouterj commented Nov 9, 2016

ping

@wouterj
Copy link
Member

wouterj commented Nov 19, 2016

Updated the PR, please review

Copy link
Member Author

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks @wouterj for making the needed updates.

@xabbuh
Copy link
Member

xabbuh commented Jan 10, 2017

Thank you Javier.

xabbuh added a commit that referenced this pull request Jan 10, 2017
…eguiluz, wouterj)

This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #7052).

Discussion
----------

Added an article about private console commands

This documents symfony/symfony#20029.

Commits
-------

d1cb043 Reflect private to hidden renaming in the file name
01f474f Reflect renaming from private to hidden
9415643 Added an article about private console commands
@xabbuh xabbuh closed this Jan 10, 2017
@javiereguiluz javiereguiluz deleted the console_private_commands branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants