Skip to content

Added note on ODM id notation being different #7092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

toby-griffiths
Copy link
Contributor

As the ODM YML notation for the id field is different, I've added a note, as I spent ages wondering why it wasn't working for me.

As the ODM YML notation for the `id` field is different, I've added a note, as I spent ages wondering why it wasn't working for me.
@xabbuh
Copy link
Member

xabbuh commented Oct 27, 2016

I don't think we should add the note in this specific place. The Doctrine chapter is one of the basic chapters and adding a note about the unrelated ODM package will probably cause more confusion. Actually we don't have anything related to the MongoDB Doctrine integration in the Symfony documentation itself. Probably this should rather be added to the ODM documentation instead.

@toby-griffiths
Copy link
Contributor Author

@xabbuh I agree to an extent, but when the page relates to just Doctrine, rather than Doctrine ORM, then it can easily be misunderstood as applying to the various Doctrine packages, as it includes an ORM specific example. I lost about 1/2 an hour trying to work out why this wasn't working for me using the MongoDB packages, so even a small note, or an updated example to include the ODM version would have help me save that wasted time. Your thoughts?

@xabbuh
Copy link
Member

xabbuh commented Oct 28, 2016

@toby-griffiths What do you think about adding a general note at the top of the page stating that this chapter does cover the Doctrine ORM package specifically?

@wouterj
Copy link
Member

wouterj commented Oct 28, 2016

Thanks for reporting this issue @toby-griffiths! This clearly is something that confused you, so let's find a solution.

I agree with @xabbuh that the current proposal may not be suited for the main Doctrine guide. Also, if we're adding ODM information in this chapter, we should also add docs for other ODMs than MongoDB imo. That'll increase complexity of this chapter, which we should avoid as it's the start guide.

On the other hand, adding a tip indicating that this is for the ORM seems a bit too verbose to me. It'll take a couple of sentences + a distracting box to tell people it's only for the ORM (and many people reading this chapter for the first time won't even know what an ORM is).

That's said, we still have this issue. What about adding "ORM" to the guide name: "Databases (Doctrine ORM)" in the sidebar and "Databases and the Doctrine ORM" as title (or the like)?

@toby-griffiths
Copy link
Contributor Author

@xabbuh I'm not sure, as I (& therefore probably others) jump around the documentation, not reading it all, in search of the answers… putting it away from the example means people might miss it, although @wouterj's suggestion to change the title seems like good enough solution, as you (almost) always read the title of the page to before it's content, to verify it's on the right topic. It, therefore, might help prevent confusion.
Alternatively, perhaps just a comment in the example code, but still this doesn't feel as clean a solution.

@wouterj
Copy link
Member

wouterj commented Nov 1, 2016

@toby-griffiths can you please update this PR to update the title of the article instead of adding this note? Thanks! (if you can't, just comment and we'll do it)

/ping @javiereguiluz as you are the only one of us that's able to change the title name in the sidebar.

@javiereguiluz
Copy link
Member

@wouterj the change has been made on symfony.com (it'll be available after the next deployment):

doctrine_orm

This PR has also been updated with your proposal.

@xabbuh
Copy link
Member

xabbuh commented Nov 3, 2016

👍

Status: Reviewed

@toby-griffiths
Copy link
Contributor Author

Thanks :)

@wouterj
Copy link
Member

wouterj commented Nov 4, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented Nov 5, 2016

Thank you @toby-griffiths.

xabbuh added a commit that referenced this pull request Nov 5, 2016
…iths, javiereguiluz)

This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #7092).

Discussion
----------

Added note on ODM id notation being different

As the ODM YML notation for the `id` field is different, I've added a note, as I spent ages wondering why it wasn't working for me.

Commits
-------

0c07271 Removed the proposed note and updated the title
21733af Added note on ODM id notation being different
@xabbuh xabbuh closed this Nov 5, 2016
@toby-griffiths
Copy link
Contributor Author

:) No worries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants