-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Better explain the most common problems when testing emails #7115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
If the action that sends the email redirects to another page (for example when | ||
you send an email after a form is processed and before redirecting to another | ||
page) make sure that the test client doesn't follow the redirects, as explained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing comma after the closing parenthesis
If the action that sends the email redirects to another page (for example when | ||
you send an email after a form is processed and before redirecting to another | ||
page), make sure that the test client doesn't follow the redirects, as explained | ||
in :doc:`/testing`. Otherwise, the collector will lose the original email when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last sentence is a bit misleading. It's not that the collector loses the mail, but that you are just looking at the "wrong" profile after being redirected, right?
👍 Great work Javier! Status: Reviewed |
Are there any specific error messages/problem descriptions that lead to one of these 2 problems? I like troubleshooting sections, but it would be even greater if it's structured like:
|
@wouterj I agree. I've added some subtitles. Thanks! |
(btw, my subtitles where just examples, I don't know if these are the true indicators of the problems). If you've checked the cases: 👍 Otherwise, please check before merging :) |
@javiereguiluz What about Wouter's last comment? |
@xabbuh I've made some minor rewords. |
Thank you @javiereguiluz. |
…ls (javiereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #7115). Discussion ---------- Better explain the most common problems when testing emails Testing emails is simple but in the past I've suffered lots of problems related to this. In fact, a few minutes ago I fixed a long standing wrong test thanks to this comment about page redirections and collectors: symfony/symfony#20282 (comment) I propose to create a new mini section to better explain the problems that you may face when testing emails. Commits ------- c2e0608 Better explain the most common problems when testing emails
* 2.7: (31 commits) fix a typo [#7115] fix headlines Better explain the most common problems when testing emails Clarify the mappings that require no method prefix. Make some long lines shorter to fit our soft limit of 80 chars per line Microsoft Azure update step by step article and screenshots for the new Microsoft Azure Portal Minor rewords in the text and the code example Update questionhelper.rst Add docs about console question answer normalizing. [#7105] add XML and PHP service config examples Minor rewordings When talking about generic responses, don't spell it as Response (which is a Symfony class) xabbuh review fix typo fix yml marker to yaml add documentation about access denied handler Update outdated link to AWS ELB security groups Added missing comma Reworded the caution about open redirects Warn user about open redirects ...
* 2.8: (37 commits) fix a typo [#7115] fix headlines Better explain the most common problems when testing emails Clarify the mappings that require no method prefix. Make some long lines shorter to fit our soft limit of 80 chars per line Microsoft Azure update step by step article and screenshots for the new Microsoft Azure Portal Minor rewords in the text and the code example Update questionhelper.rst Add docs about console question answer normalizing. [#7105] add XML and PHP service config examples Minor rewordings When talking about generic responses, don't spell it as Response (which is a Symfony class) xabbuh review fix typo fix yml marker to yaml add documentation about access denied handler Update outdated link to AWS ELB security groups Added missing comma Reworded the caution about open redirects Warn user about open redirects ...
* 3.1: (41 commits) fix a typo [#7115] fix headlines Better explain the most common problems when testing emails Clarify the mappings that require no method prefix. Make some long lines shorter to fit our soft limit of 80 chars per line Microsoft Azure update step by step article and screenshots for the new Microsoft Azure Portal Minor rewords in the text and the code example Update questionhelper.rst Add docs about console question answer normalizing. [#7105] add XML and PHP service config examples Minor rewordings When talking about generic responses, don't spell it as Response (which is a Symfony class) xabbuh review fix typo fix yml marker to yaml add documentation about access denied handler Update outdated link to AWS ELB security groups Added missing comma Reworded the caution about open redirects Warn user about open redirects ...
Testing emails is simple but in the past I've suffered lots of problems related to this. In fact, a few minutes ago I fixed a long standing wrong test thanks to this comment about page redirections and collectors: symfony/symfony#20282 (comment)
I propose to create a new mini section to better explain the problems that you may face when testing emails.