Added documentation for DbalSessionHandler as there is none #7132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
wouterj
reviewed
Nov 11, 2016
changelog.rst
Outdated
| @@ -13,6 +13,17 @@ documentation. | |||
| Do you also want to participate in the Symfony Documentation? Take a look | |||
| at the ":doc:`/contributing/documentation/overview`" article. | |||
|
|
|||
| November, 2016 | |||
There was a problem hiding this comment.
The changelogs are automatically generated based on the merge commits. Please remove the changes in this file.
There was a problem hiding this comment.
My apologies. I'll remove the change log changes and rebase the latest changes with master.
|
DbalSessionHandler is probably going to be deprecated. In that case, should we document it? |
HeahDude
approved these changes
Jul 29, 2017
| @@ -13,78 +13,6 @@ documentation. | |||
| Do you also want to participate in the Symfony Documentation? Take a look | |||
| at the ":doc:`/contributing/documentation/overview`" article. | |||
|
|
|||
| October, 2016 | |||
There was a problem hiding this comment.
Those changes should be reverted.
|
@HeahDude If this documentation is still wanted (seeing as DbalSessionHandler is to be deprecated), I'll revert the |
|
Closing this issue as the code is being deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written this documentation for the DbalSessionHandler as there was none, at least, none that was specifically about this class (even though one exists for the PdoSessionHandler).