Add a warning about routes parameters names limitations #7133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 3.0 branch. Discussion ---------- after merge fixes Commits ------- b9ebf03 after merge fixes
* 3.0: after merge fixes fix some issues after merging 2.7 into 2.8 fix another bug due to choosing the wrong branch Update some screenshots to wrap them with a browser window some minor tweaks fix bugs due to choosing the wrong base branch complete component cross references Updated the Global Composer Installation article Removing an index to forms - this seemed to cause big errors in how the index/breadcrumbs were built Switching wrong link order
* 3.1: after merge fixes fix some issues after merging 2.7 into 2.8 fix another bug due to choosing the wrong branch Update some screenshots to wrap them with a browser window some minor tweaks fix bugs due to choosing the wrong base branch complete component cross references Updated the Global Composer Installation article Removing an index to forms - this seemed to cause big errors in how the index/breadcrumbs were built Switching wrong link order
* 2.8: Correcting reference to `isSuccessful` method for Process Update custom_constraint.rst Minor fix Fixed typo Discourage the use of controllers as services Add constants to BC promise Remove complex DI extension information and link the cookbook article instead Trying to remove some duplication and some extra details
* 3.0: Correcting reference to `isSuccessful` method for Process Update custom_constraint.rst Minor fix Fixed typo Discourage the use of controllers as services Add constants to BC promise Remove complex DI extension information and link the cookbook article instead Trying to remove some duplication and some extra details
* 3.1: Correcting reference to `isSuccessful` method for Process Update custom_constraint.rst Minor fix Fixed typo Discourage the use of controllers as services Add constants to BC promise Remove complex DI extension information and link the cookbook article instead Trying to remove some duplication and some extra details
* mercury/2.8: (194 commits) fix some issues after merging 2.7 into 2.8 fix another bug due to choosing the wrong branch Update some screenshots to wrap them with a browser window some minor tweaks fix bugs due to choosing the wrong base branch complete component cross references Updated the Global Composer Installation article Removing an index to forms - this seemed to cause big errors in how the index/breadcrumbs were built Switching wrong link order Remove mentions of (cook)book Fix build Remove mentions of cookbook/book making sure the getting started navigation is smooth Add file extension to SOAP article Rename cache/ to http_cache/ Correcting the "next" page to point to creating pages Rewords Tweaking our fake homepage - there isn't a book or cookbook exactly Tweaking our fake index page so that Getting Started doesn't make a huge, deep list Fixing build issues ...
* mercury/3.0: (200 commits) after merge fixes fix some issues after merging 2.7 into 2.8 fix another bug due to choosing the wrong branch Update some screenshots to wrap them with a browser window some minor tweaks fix bugs due to choosing the wrong base branch complete component cross references Updated the Global Composer Installation article Removing an index to forms - this seemed to cause big errors in how the index/breadcrumbs were built Switching wrong link order Remove mentions of (cook)book Fix build Fix build Remove mentions of cookbook/book making sure the getting started navigation is smooth Add file extension to SOAP article Rename cache/ to http_cache/ Correcting the "next" page to point to creating pages Rewords Tweaking our fake homepage - there isn't a book or cookbook exactly ...
* mercury/3.1: (202 commits) after merge fixes fix some issues after merging 2.7 into 2.8 fix another bug due to choosing the wrong branch Update some screenshots to wrap them with a browser window some minor tweaks fix bugs due to choosing the wrong base branch complete component cross references Updated the Global Composer Installation article Removing an index to forms - this seemed to cause big errors in how the index/breadcrumbs were built Switching wrong link order Remove mentions of (cook)book Remove mentions of (cook)book Fix build Fix build Remove mentions of cookbook/book making sure the getting started navigation is smooth Add file extension to SOAP article Rename cache/ to http_cache/ Correcting the "next" page to point to creating pages Rewords ...
* mercury/master: (205 commits) after merge fixes fix some issues after merging 2.7 into 2.8 fix another bug due to choosing the wrong branch Update some screenshots to wrap them with a browser window some minor tweaks fix bugs due to choosing the wrong base branch complete component cross references Updated the Global Composer Installation article Removing an index to forms - this seemed to cause big errors in how the index/breadcrumbs were built Switching wrong link order Remove mentions of (cook)book Remove mentions of (cook)book Fix build Fix build Remove mentions of cookbook/book making sure the getting started navigation is smooth Add file extension to SOAP article Rename cache/ to http_cache/ Correcting the "next" page to point to creating pages Rewords ...
* 3.1:
* 2.7: fix syntax errors fix code block indentation
* 2.8: fix syntax errors fix code block indentation
* 3.0: fix syntax errors fix code block indentation
* 3.1: fix syntax errors fix code block indentation
This PR was merged into the master branch.
Discussion
----------
Fix web/front.php
## $controller always return false.
$controller = $controllerResolver->getController($request);
$arguments = $argumentResolver->getArguments($request, $controller);
The two lines before the `try ... catch` should run after:
$request->attributes->add($matcher->match($request->getPathInfo()));
The three lines already exist inside the `try ... catch` which works fine and properly after removed those two lines.
([http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html](http://symfony.com/doc/master/create_framework/http_kernel_controller_resolver.html))
Commits
-------
86bb5ac Fix web/front.php
The link to the UserCheckerInterface seems to be wrong.
This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closes symfony#6761). Discussion ---------- fixed missing level in namespace The link to the UserCheckerInterface seems to be wrong. Commits ------- 8d60d5c fixed missing level in namespace
* 2.7: (51 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and @snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required after symfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter Fixed a DI redirection ...
* 2.8: (52 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and @snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement fixed missing level in namespace Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required after symfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter ...
* 3.0: (52 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and @snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement fixed missing level in namespace Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required after symfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter ...
* 3.1: (52 commits) this sounds just a little bit more natural Update dynamic_form_modification.rst Remove colloquialism "hold on" fixing reference to deprecated class removing use statement for consistency with other places in this doc fix FlattenException namespace Tweaks thanks to close review from Javier and @snoek09! Remove AcmeDemoBundle references Fix reference to output object Subject-verb agreement fixed missing level in namespace Fix tense and sentence length Fix typo in external_parameters.rst line break Removing the alias stuff - not required after symfony/symfony#17074 Fixed the main index page redirections Fixed the redirection for "upgrade" articles Added all the missing "index pages" redirections Fixed a Console article redirection Fixed the redirection of the previous "performance" book chapter ...
Sinced Sy3 they are under `var` instead of `app`.
…ana-gligor) This PR was submitted for the 3.1 branch but it was merged into the 3.0 branch instead (closes symfony#6825). Discussion ---------- update `cache` and `logs` folder locations Since Sy3 they are under `var` instead of `app`. Commits ------- 396cf06 update `cache` and `logs` folder locations
…lchimik) This PR was merged into the 3.1 branch. Discussion ---------- Simplex\Framework - add argumentResolver property Commits ------- 2611798 Simplex\Framework - add argumentResolver property
* 2.7: Remove suggestion to change the parameters Also mention "hassers" A bracket was missed Improved Redirecting paragraph of Testing page link to specific HTTP Cache RFC Added jQuery symfony-collection plugin to Form collection docs Update bug documintation input console /console/input.rst Update custom_authentication_provider.rst update github example Update metadata.rst
* 2.8: Remove suggestion to change the parameters Also mention "hassers" A bracket was missed Update birthday.rst Improved Redirecting paragraph of Testing page link to specific HTTP Cache RFC Added jQuery symfony-collection plugin to Form collection docs Update bug documintation input console /console/input.rst Update custom_authentication_provider.rst update github example Update metadata.rst remove caution message
* 3.1: Remove suggestion to change the parameters Also mention "hassers" A bracket was missed Update birthday.rst Improved Redirecting paragraph of Testing page link to specific HTTP Cache RFC Added jQuery symfony-collection plugin to Form collection docs Update bug documintation input console /console/input.rst Update custom_authentication_provider.rst update github example Update metadata.rst remove caution message Simple typo fix
This PR was merged into the 3.1 branch. Discussion ---------- [Profiler] Fix rst typo Commits ------- b7056b6 [Profiler] Fix rst typo
…dreybolonin) This PR was merged into the 3.1 branch. Discussion ---------- fixed app/console to bin/console on 3.1 branch Instead of symfony#7106. From 3.1 fork to 3.1 branch. Commits ------- cfaaf08 Update input.rst
…(alexpts) This PR was squashed before being merged into the 3.1 branch (closes symfony#7101). Discussion ---------- Remove AssetsHelper from the templating component > > deprecated since 2.7, will be removed in 3.0. Use the Asset component instead. Commits ------- 4a17054 Remove AssetsHelper from the templating component
This PR was squashed before being merged into the master branch (closes symfony#6953). Discussion ---------- Documented the Lockable Trait This fixes symfony#6678 Commits ------- b0495e0 Documented the Lockable Trait
This PR was merged into the master branch. Discussion ---------- [symfony#6947] some minor tweaks Commits ------- f865f93 [symfony#6947] some minor tweaks
* 2.7: [symfony#6961] add additional config formats [symfony#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [symfony#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks [Doctrine] Exception note about functions with named managers
* 2.8: [symfony#6961] add additional config formats [symfony#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [symfony#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks [Doctrine] Exception note about functions with named managers
* 3.1: [symfony#6961] add additional config formats [symfony#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [symfony#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Remove AssetsHelper from the templating component Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks Update input.rst [Profiler] Fix rst typo [Doctrine] Exception note about functions with named managers
wouterj
reviewed
Nov 11, 2016
| @@ -466,6 +466,10 @@ a slash. URLs matching this route might look like: | |||
| Symfony provides you with a way to do this by leveraging service container | |||
| parameters. Read more about this in ":doc:`/routing/service_container_parameters`". | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| A route parameter name cannot start with a digit and cannot be longer than 32 characters. | |||
There was a problem hiding this comment.
Please use 4 spaces to indent the content of the caution directive.
|
👍 (left one minor comment, but this can be fixed while merging) status: reviewed |
|
👍 |
|
Hm, what do you think to move this up to the "Routing Examples" section to make it more visible to the reader? |
xabbuh
added a commit
that referenced
this pull request
Nov 22, 2016
…fancyweb, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Add a warning about routes parameters names limitations @wouterj @xabbuh I'm sorry guys I had to do a new branch and a new PR because I failed in the old one. I shouldn't have used the fast GitHub edit method. I fixed the indentation to 4 spaces. Also I thought this kind of information fitted more in the "advanced" area along with the special parameters than in the basic examples. Follow up to #7133 Commits ------- cadef60 Use "route placeholder" instead of "route parameter" 6b0f53c Add a warning about routes parameters names limitations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.