Skip to content

Added a comment to prevent people from manually updating the changelog #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2016

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Nov 11, 2016

For instance, to prevent things like #7132

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,5 +1,9 @@
.. index::
single: CHANGELOG

.. !! CAUTION !!
This file is automatically generated each month. Do not add new changelog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove each month to not constraint ourselves and be able to change the frequency as needed.


.. !! CAUTION !!
This file is automatically generated each month. Do not add new changelog
items when preparing a pull requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a pull requests. -> a pull request.

@xabbuh
Copy link
Member

xabbuh commented Nov 12, 2016

👍

@xabbuh
Copy link
Member

xabbuh commented Nov 22, 2016

Thank you Wouter.

@xabbuh xabbuh merged commit 6958b7c into 2.7 Nov 22, 2016
xabbuh added a commit that referenced this pull request Nov 22, 2016
…the changelog (wouterj)

This PR was merged into the 2.7 branch.

Discussion
----------

Added a comment to prevent people from manually updating the changelog

For instance, to prevent things like #7132

Commits
-------

6958b7c Added a comment to prevent people from manually updating the changelog
xabbuh added a commit that referenced this pull request Nov 22, 2016
@xabbuh xabbuh deleted the wouterj-changelog_comment branch November 22, 2016 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants