Added Doctrine entities and documents to the list of known locations for classes #7156
Conversation
|
👍 |
bundles/best_practices.rst
Outdated
| Event Listeners ``EventListener/`` No | ||
| Configuration ``Resources/config/`` No | ||
| Web Resources (CSS, JS, images) ``Resources/public/`` Yes | ||
| Translation files ``Resources/translations/`` Yes |
There was a problem hiding this comment.
To complete the PR, WDYT about adding /Resources/config/validation and /Resources/config/serialization too?
There was a problem hiding this comment.
I'm not sure because those directories are optional when using annotations. In this case, I'd also like to have a dedicated article to explain these things, as stated in a previous comment.
bundles/best_practices.rst
Outdated
| Commands ``Command/`` Yes | ||
| Controllers ``Controller/`` No | ||
| Service Container Extensions ``DependencyInjection/`` Yes | ||
| Doctrine entities and documents ``Entity/`` (ORM) or ``Document/`` (ODM) No |
There was a problem hiding this comment.
Why did you tag this as not mandatory?
There was a problem hiding this comment.
Because thanks to the doctrine.orm.mapings you can store your entities anywhere you like, even outside the bundles.
In any case, I dislike this Mandatory column more and more. The intention is good, but this cannot simply be answered by Yes or No. I propose to remove this column and add a new article explaining how to override the location every single part of the bundle: controllers, templates, entities, commands, etc.
There was a problem hiding this comment.
The same argument applies to nearly all other rows where have set this column to "yes". So I would rather say let's remove the column.
There was a problem hiding this comment.
By the way, we have such an article: http://symfony.com/doc/current/bundles/override.html
There was a problem hiding this comment.
👍 for removing this column.
There was a problem hiding this comment.
see also #8269 which made some changes in the 3.4 branch because auto-discovering commands based on their location will be deprecated
…n locations for classes (javiereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #7156). Discussion ---------- Added Doctrine entities and documents to the list of known locations for classes Commits ------- 8764708 Final updates 469d0ea Added Doctrine entities and documents to the list of known locations for classes
No description provided.