Fixed the signature of prepend method in the code example #7240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PrependExtensionInterface::prepend` has one parameter: `$container`. From the current example it is not clear how `$container` appeared in the method body. Anyway, it is better to have here correct code examples.
|
👍 Status: Reviewed |
|
Good catch, thanks @a-ast. |
xabbuh
added a commit
that referenced
this pull request
Dec 12, 2016
… (a-ast) This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7240). Discussion ---------- Fixed the signature of prepend method in the code example `PrependExtensionInterface::prepend` has one parameter: `$container`. From the current example it is not clear how `$container` appeared in the method body. Anyway, it is better to have here correct code examples. Commits ------- 9f77757 Fixed the signature of prepend method in the code example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrependExtensionInterface::prependhas one parameter:$container. From the current example it is not clear how$containerappeared in the method body. Anyway, it is better to have here correct code examples.