Changed option guessing to maxlength #7273
Conversation
HTML attribute for max length is ``maxlength``.
| @@ -562,8 +562,8 @@ the correct values of a number of field options. | |||
| field ``nullable``). This is very useful, as your client-side validation will | |||
| automatically match your validation rules. | |||
|
|
|||
| ``max_length`` | |||
| If the field is some sort of text field, then the ``max_length`` option can be | |||
| ``maxlength`` | |||
There was a problem hiding this comment.
Thanks for opening this PR! This change is legit, but I think you should also replace option by html attribute for both this one and required above. since this does not use the options at all, but the attr option, btw max_length option has been deprecated in 2.5.
|
Thanks for the comment @HeahDude |
| @@ -542,11 +542,11 @@ the guessed field. | |||
| .. index:: | |||
| single: Forms; Field type guessing | |||
|
|
|||
| Field Type Options Guessing | |||
| Field Attributes Guessing | |||
There was a problem hiding this comment.
I understand why you did it but this change is not needed since guessers are about to change type's options, actually required and maxlength are define thanks to the attr option in the form factory but the registered doctrine and validation guessers are setting some options too, maybe it's worth documenting them though. I don't know what others think?
There was a problem hiding this comment.
Do you think we should just remove the maxlength part and keep required?
There was a problem hiding this comment.
No I don't :) I was suggesting to add undocumented guessed options, not to remove these ;)
There was a problem hiding this comment.
This change also needs to be reverted.
|
I suggest to merge this PR as is, and add proper documentation for guessed options in another one. @TheYouX Could you please rebase? |
HTML attribute name is 'maxlength' instead of 'max_length'.