Skip to content

Update voters.rst #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update voters.rst #7279

wants to merge 2 commits into from

Conversation

ErikRoelofs
Copy link

Made clear the difference between using denyAccessUnlessGranted and isGranted - the former is not just a shortcut to calling isGranted.

Made clear the difference between using denyAccessUnlessGranted and isGranted - the former is NOT just a shortcut to calling isGranted.
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1

@javiereguiluz
Copy link
Member

@ErikRoelofs I like this proposal ... but I've added a minor (optional) reword. If you don't agree with it, please tell me. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Dec 25, 2016

Thank you @ErikRoelofs.

xabbuh added a commit that referenced this pull request Dec 25, 2016
This PR was submitted for the 3.2 branch but it was merged into the 2.8 branch instead (closes #7279).

Discussion
----------

Update voters.rst

Made clear the difference between using denyAccessUnlessGranted and isGranted - the former is not just a shortcut to calling isGranted.

Commits
-------

4023044 Minor reword
188b654 Update voters.rst
@xabbuh xabbuh closed this Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants