[PhpUnitBridge] clarify silencing deprecations in tests #7323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/phpunit_bridge.rst
Outdated
| * Make its data provider start with ``provideLegacy*()`` or ``getLegacy*()``. | ||
| .. note:: | ||
|
|
||
| You can make your data provider start with ``provideLegacy*()`` or ``getLegacy*()`` |
There was a problem hiding this comment.
I'd like to have more information about this:
- If I name a data provider as
provideLegacy()andgetLegacy()... will the tests that use that provider be considered legacy automatically? - If I declare a test as legacy ... am I required to call its data provider as
provideLegacy()andgetLegacy()too?
There was a problem hiding this comment.
So, any comment about my questions? Thanks!
|
@javiereguiluz Sorry for the delay. I pushed an update here. Do you think it's more clear now? |
HeahDude
reviewed
Jul 29, 2017
| code, it is not required to choose a special naming just because the | ||
| test being fed by the data provider is marked as legacy. | ||
|
|
||
| Also be aware that choosing one of the two legacy prefixes will not mark |
There was a problem hiding this comment.
"one of the" => "one of these"?
|
Thank you Christian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #7312.