Added a note about not using the ClassLoader component #7383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jan 18, 2017
|
|
||
| If your application uses Composer's class loading mechanism and PHP 7 caching | ||
| features, there's no need to use this component to load classes. That's why | ||
| this component may be deprecated anytime soon. |
There was a problem hiding this comment.
The last sentence sounds a bit vague. Shouldn't we just omit it?
There was a problem hiding this comment.
I've reworded it ... because the component is deprecated as of symfony/symfony#21353
xabbuh
reviewed
Jan 20, 2017
| .. caution:: | ||
|
|
||
| The ClassLoader component was deprecated in Symfony 3.3 and it will be | ||
| removed in 4.0. Alternatively, use the Composer's class loading mechanism. |
xabbuh
reviewed
Jan 20, 2017
| @@ -7,6 +7,11 @@ The ClassLoader Component | |||
| The ClassLoader component provides tools to autoload your classes and | |||
| cache their locations for performance. | |||
|
|
|||
| .. caution:: | |||
|
|
|||
| The ClassLoader component was deprecated in Symfony 3.3 and it will be | |||
There was a problem hiding this comment.
Technically, using the past tense here is not correct as 3.3 was released yet. Though I think that's okay as it allows us not to update the sentence in May again. What do you think?
There was a problem hiding this comment.
I agree. It's not perfect, but it's "good enough".
|
Okay, let's keep it as is. Status: Reviewed |
xabbuh
added a commit
that referenced
this pull request
Feb 3, 2017
…aviereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #7383). Discussion ---------- Added a note about not using the ClassLoader component This fixes #5949. The component will be deprecated soon, so I guess it's OK to start warning our users. Commits ------- e96cbf8 Added a note about not using the ClassLoader component
|
Thank you Javier. I made a minor rewording in 0866fb8. Please let me know if you do not agree. |
xabbuh
added a commit
that referenced
this pull request
Feb 3, 2017
* 2.7: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions See #7362 bundles/override > Rewrite translations block
xabbuh
added a commit
that referenced
this pull request
Feb 3, 2017
* 2.8: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component Update guard_authentication.rst More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions See #7362 bundles/override > Rewrite translations block
xabbuh
added a commit
that referenced
this pull request
Feb 3, 2017
* 3.1: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component Update guard_authentication.rst More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions remove unused options parameter from loadManifest See #7362 bundles/override > Rewrite translations block
xabbuh
added a commit
that referenced
this pull request
Feb 3, 2017
* 3.2: [#7427] fix line length Add apcu cache driver to doctrine config reference Change type of arguments min and max [#7383] minor rewording Added a note about not using the ClassLoader component Update guard_authentication.rst More clear description of factory service creation [#7376] minor wording improvement Added a tip about the expanded YAML syntax Added a minor help note about Request::setTrustedProxies Fix Apache 2.4 UDS instructions Fix doc for yaml parameters constants usage remove unused options parameter from loadManifest Tweaks based on feedback! Covering two missing adapters introduced in 3.2 See #7362 bundles/override > Rewrite translations block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5949.
The component will be deprecated soon, so I guess it's OK to start warning our users.