Skip to content

[WCM][Routing] Update default attributes example for annotations #7408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jan 23, 2017

symfony/symfony#21333 removed the autowiring of request attributes based on method arguments default values when using the @Route annotation.
This feature was causing an annoying bug on argument resolvers and was inconsistent with other configuration formats which force to define the attributes explicitly.

This fixes the corresponding routing example. On hold until symfony/symfony#21377 is merged.

@chalasr
Copy link
Member Author

chalasr commented Jan 23, 2017

Closing as we can get rid of this BC break, see symfony/symfony#21379

@chalasr chalasr closed this Jan 23, 2017
@chalasr chalasr deleted the routing/update-annotation-example branch January 23, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants