Use the Ldap factory in the ldap service definition #7413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
requested changes
Jan 30, 2017
security/ldap.rst
Outdated
| @@ -94,12 +105,16 @@ definition: | |||
|
|
|||
| $container | |||
| ->setDefinition('ldap', new Definition(LdapClient::class, array( | |||
There was a problem hiding this comment.
Looks like you need to update the class name here and add the factory too.
|
@nietonfir I would advise you to make your pull request against the existing PR for the 3.1 version of the component: See #6982 |
2afbe31 to
45e8da5
Compare
1cfe6e7 to
7ba300c
Compare
security/ldap.rst
Outdated
| port: '389' # port | ||
| version: 3 # version | ||
| encryption: 'none' # either 'tls', 'ssl' or 'none' | ||
| debug: false, # Enable debugging output |
javiereguiluz
approved these changes
Jul 9, 2017
|
👍 |
|
@nietonfir I am sorry that we did not merge your PR earlier. In the meantime, support was dropped for Symfony 3.1 and 3.2 and we did some other changes to the Ldap component docs. Could you rebase your PR onto the |
78acdb0 to
d428f8d
Compare
|
Done. |
xabbuh
approved these changes
Sep 19, 2017
|
@nietonfir thanks for this contribution and I'm sorry it took us so long to merge this. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2018
…razi) This PR was merged into the 3.3 branch. Discussion ---------- Use the Ldap factory in the ldap service definition as LdapClient has been marked deprecated in 3.1. Refs symfony/symfony#19008 @csarrazi Hope this is correct. Commits ------- d428f8d Updated LDAP documentation for Symfony 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as LdapClient has been marked deprecated in 3.1.
Refs symfony/symfony#19008
@csarrazi Hope this is correct.