Skip to content

Update doctrine.rst #7456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Update doctrine.rst #7456

wants to merge 2 commits into from

Conversation

patie
Copy link
Contributor

@patie patie commented Feb 9, 2017

schema_filter option should be full regular

javiereguiluz
javiereguiluz approved these changes Feb 9, 2017
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Nice catch fixing this error. I've changed your PR a bit to improve the original description and example. Thanks!

@xabbuh
Copy link
Member

xabbuh commented Feb 19, 2017

Thank you @patie.

xabbuh added a commit that referenced this pull request Feb 19, 2017
@xabbuh
minor #7456 Update doctrine.rst (patie, javiereguiluz)
52072d1 
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7456).

Discussion
----------

Update doctrine.rst

schema_filter option should be full regular

Commits
-------

1ad7eef Expanded the explanation and updated the example
6f31645 Update doctrine.rst
@xabbuh xabbuh closed this Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patie @xabbuh @javiereguiluz @carsonbot