Skip to content

added a tip to register annotations namespaces #7511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

wolfwolker
Copy link

No description provided.

@xabbuh
Copy link
Member

xabbuh commented Feb 18, 2017

I am not against adding such a tip. But I suggest that we check all other places where we document the use of annotations in the components section and write a generic tip that we could include everywhere.

@HeahDude
Copy link
Contributor

Hello @wolfwolker, would you like to address @xabbuh's comment?

@wolfwolker
Copy link
Author

Thanks for remember it to me @HeahDude. Yes I totally agree with @xabbuh, but I've been very busy these past weeks. I'm gonna try to add the tip also to other components sections in the following days.

@HeahDude
Copy link
Contributor

ping @wolfwolker :) Are you still interested in finishing this PR?

@HeahDude HeahDude added this to the 2.7 milestone Jul 29, 2017
@wolfwolker
Copy link
Author

ups, totally forgot about it. I'll address it for this week. My apologies @HeahDude

@HeahDude
Copy link
Contributor

No worries :), thanks!

@wolfwolker wolfwolker force-pushed the improve_validator_component_chapter branch from 590a8d7 to 84c1541 Compare August 6, 2017 11:23
@wolfwolker
Copy link
Author

wolfwolker commented Aug 6, 2017

well, It's done. I created a snippet file under _includes directory with the tips and included it in three places I found with annotations loader usage.

But I'm not sure if it is working, how can I see these rst files with the symfony docs web look and feel?

If you like the result I'll squash both commits into a single one

@@ -314,6 +314,8 @@ You are now able to serialize only attributes in the groups you want::

.. _ignoring-attributes-when-serializing:

.. include:: /_includes/_rewrite_rule_tip.rst.inc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be moved before the previous label.

@javiereguiluz
Copy link
Member

@xabbuh I did all the changes you asked for. We should check if this note is still relevant for newer Symfony versions. Thanks!

@javiereguiluz
Copy link
Member

@wolfwolker it took us a long time to merge your contribution, but we finally did. Thank you and congrats on your first Symfony Docs contribution!

@javiereguiluz javiereguiluz merged commit 1ce3a43 into symfony:2.7 Jan 12, 2018
javiereguiluz added a commit that referenced this pull request Jan 12, 2018
…ia, Noel, javiereguiluz)

This PR was merged into the 2.7 branch.

Discussion
----------

added a tip to register annotations namespaces

Commits
-------

1ce3a43 Removed the reference to specific Symfony files
f56b5af Moved the note before the label
19c89da Minor reword
0ddf3d2 moved the tips to an include fragment file
84c1541 added a tip to register annotations namespaces
@wolfwolker
Copy link
Author

thks @javiereguiluz ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants