-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
added a tip to register annotations namespaces #7511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a tip to register annotations namespaces #7511
Conversation
I am not against adding such a tip. But I suggest that we check all other places where we document the use of annotations in the components section and write a generic tip that we could include everywhere. |
Hello @wolfwolker, would you like to address @xabbuh's comment? |
ping @wolfwolker :) Are you still interested in finishing this PR? |
ups, totally forgot about it. I'll address it for this week. My apologies @HeahDude |
No worries :), thanks! |
590a8d7
to
84c1541
Compare
well, It's done. I created a snippet file under _includes directory with the tips and included it in three places I found with annotations loader usage. But I'm not sure if it is working, how can I see these rst files with the symfony docs web look and feel? If you like the result I'll squash both commits into a single one |
components/serializer.rst
Outdated
@@ -314,6 +314,8 @@ You are now able to serialize only attributes in the groups you want:: | |||
|
|||
.. _ignoring-attributes-when-serializing: | |||
|
|||
.. include:: /_includes/_rewrite_rule_tip.rst.inc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should be moved before the previous label.
@xabbuh I did all the changes you asked for. We should check if this note is still relevant for newer Symfony versions. Thanks! |
@wolfwolker it took us a long time to merge your contribution, but we finally did. Thank you and congrats on your first Symfony Docs contribution! |
…ia, Noel, javiereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- added a tip to register annotations namespaces Commits ------- 1ce3a43 Removed the reference to specific Symfony files f56b5af Moved the note before the label 19c89da Minor reword 0ddf3d2 moved the tips to an include fragment file 84c1541 added a tip to register annotations namespaces
thks @javiereguiluz ;) |
No description provided.