Made 'create-user' command consistent. #7551
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a very minor inconsistency between the naming of the 'create users' command at the beginning of the document and the 'create user' command for the rest of the article. It starts with the plural, then changes to singular. A very minor thing, but when you're following the documentation precisely, this inconsistency raises unnecessary questions. Updated all references to 'create-user'.
|
👍 Status: Reviewed |
HeahDude
reviewed
Mar 1, 2017
|
|
||
| // the full command description shown when running the command with | ||
| // the "--help" option | ||
| ->setHelp('This command allows you to create users...') | ||
| ->setHelp('This command allows you to create a user...') |
There was a problem hiding this comment.
I would say 'This command allows you to create a user...' is perfectly valid 👍
There was a problem hiding this comment.
I'm not saying it isn't :), I would just avoid the "you".
There was a problem hiding this comment.
Could I persuade you by comparing the two side by side?
'This command allows you to create a user...'
'This command allows to create a user...'
For me, the first one is nicer to read. :)
|
I have no preference either. So I merged the PR as is. Thank you @finchmeister. |
xabbuh
added a commit
that referenced
this pull request
Mar 1, 2017
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7551). Discussion ---------- Made 'create-user' command consistent. There is a very minor inconsistency between the naming of the 'create users' command at the beginning of the document and the 'create user' command for the rest of the article. It starts with the plural, then changes to singular. A very minor thing, but when you're following the documentation precisely, this inconsistency raises unnecessary questions. Updated all references to 'create-user'. Commits ------- d04bcc4 Made 'create-user' command consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a very minor inconsistency between the naming of the 'create users' command at the beginning of the document and the 'create user' command for the rest of the article. It starts with the plural, then changes to singular. A very minor thing, but when you're following the documentation precisely, this inconsistency raises unnecessary questions. Updated all references to 'create-user'.