Skip to content

Made 'create-user' command consistent. #7551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Made 'create-user' command consistent. #7551

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions console.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ method. Then you can optionally define a help message and the
{
$this
// the name of the command (the part after "bin/console")
->setName('app:create-users')
->setName('app:create-user')

// the short description shown while running "php bin/console list"
->setDescription('Creates new users.')
->setDescription('Creates a new user.')

// the full command description shown when running the command with
// the "--help" option
->setHelp('This command allows you to create users...')
->setHelp('This command allows you to create a user...')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"allows to create"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say 'This command allows you to create a user...' is perfectly valid 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not saying it isn't :), I would just avoid the "you".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could I persuade you by comparing the two side by side?

'This command allows you to create a user...'
'This command allows to create a user...'

For me, the first one is nicer to read. :)

;
}

Expand All @@ -68,7 +68,7 @@ After configuring the command, you can execute it in the terminal:

.. code-block:: terminal

$ php bin/console app:create-users
$ php bin/console app:create-user

As you might expect, this command will do nothing as you didn't write any logic
yet. Add your own logic inside the ``execute()`` method, which has access to the
Expand Down