Skip to content

Twig Extensions Reference minor brush-up #7613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Mar 11, 2017

Especially clarify that the "Twig Extensions Repository" has nothing to do with Symfony Standard Edition

Especially clarify that the "Twig Extensions Repository" has nothing to do with Symfony Standard Edition

  Technically, most of the extensions live in the `Twig Bridge`_. That code
might give you some ideas when you need to write your own Twig extension
as described in :doc:`/templating/twig_extension.rst`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to omit the file extension here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

:ref:`functions <reference-twig-functions>`, :ref:`filters <reference-twig-filters>`,
:ref:`tags <reference-twig-tags>` and :ref:`tests <reference-twig-tests>`
that are available when using the Symfony Core Framework.
The Symfony Framework adds quite a few extra :ref:`functions <reference-twig-functions>`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

framework

The Symfony Framework adds quite a few extra :ref:`functions <reference-twig-functions>`,
:ref:`filters <reference-twig-filters>`, :ref:`tags <reference-twig-tags>`
and :ref:`tests <reference-twig-tests>` to seamlessly integrate the various
Symfony Components with Twig templates. The following sections describe these
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

components


This reference only covers the Twig extensions provided by the Symfony
Framework. You are probably using some other bundles as well, and those
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

framework

.. _`the official Twig Extensions documentation`: http://twig.sensiolabs.org/doc/extensions/index.html
.. _`Twig Extensions repository`: https://github.com/twigphp/Twig-extensions
.. _`Twig Extensions documentation`: http://twig-extensions.readthedocs.io/en/latest/
.. _`KernelEvents`: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/KernelEvents.php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't used anywhere here, is it?

@mpdude
Copy link
Contributor Author

mpdude commented Mar 13, 2017

@xabbuh Thanks for the review, fixed all your remarks

@xabbuh
Copy link
Member

xabbuh commented Mar 13, 2017

👍

Status: Reviewed

@javiereguiluz
Copy link
Member

@mpdude I'm really sorry but your PR needs to be rebased. Could you do that for us? Thanks!

@mpdude
Copy link
Contributor Author

mpdude commented Apr 30, 2017

@javiereguiluz done, merged master

@javiereguiluz
Copy link
Member

javiereguiluz commented Apr 30, 2017

@mpdude thanks for your contribution and for the rebase! It's merged now.

@mpdude mpdude deleted the patch-2 branch April 30, 2017 15:09
xabbuh pushed a commit that referenced this pull request May 3, 2017
This PR was squashed before being merged into the master branch (closes #7613).

Discussion
----------

Twig Extensions Reference minor brush-up

Especially clarify that the "Twig Extensions Repository" has nothing to do with Symfony Standard Edition

Commits
-------

b48b4c4 Twig Extensions Reference minor brush-up
xabbuh added a commit that referenced this pull request May 3, 2017
* 2.7:
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Minor reword
  Update deployment.rst
  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()
  Better explain how to enable the validation component and its annotations
  Fix the link to ConEmu (it is now hosted on GitHub)
  Add annotation examples to match a route based on the host
  Minor reword to improve readability
  Minor reword and reformatting
  Add security stateless tip
  typo
xabbuh added a commit that referenced this pull request May 3, 2017
* 2.8:
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Fixed the form types of the buttons in the Form reference
  Minor reword
  Update deployment.rst
  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()
  Better explain how to enable the validation component and its annotations
  Fix the link to ConEmu (it is now hosted on GitHub)
  Add annotation examples to match a route based on the host
  Minor reword to improve readability
  Minor reword and reformatting
  Add security stateless tip
  typo
xabbuh added a commit that referenced this pull request May 3, 2017
xabbuh added a commit that referenced this pull request May 3, 2017
* 3.2: (28 commits)
  [#7613] remove reference to AsseticBundle
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Fixed the form types of the buttons in the Form reference
  [#7832] use bin/console for Symfony 3.x
  Minor reword
  Update deployment.rst
  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()
  Better explain how to enable the validation component and its annotations
  Fix the link to ConEmu (it is now hosted on GitHub)
  Add annotation examples to match a route based on the host
  Minor reword to improve readability
  Update service_container.rst
  Minor reword and reformatting
  ...
weaverryan added a commit that referenced this pull request May 5, 2017
* origin/master: (36 commits)
  Use the short Yaml syntax for service definition
  [#7613] remove reference to AsseticBundle
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Fix service locator declaration
  Minor reword
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [3.3] Document FQCN named controllers
  Document FQCN named controllers
  Use the short tag syntax
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Rewords
  Fixed the form types of the buttons in the Form reference
  [#7832] use bin/console for Symfony 3.x
  Minor reword
  Update deployment.rst
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants