[Serializer] Document the CsvEncoder and the YamlEncoder #7654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeahDude
suggested changes
Mar 26, 2017
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The ``JsonEncoder`` is much simpler and is based on the PHP | ||
| :phpfunction:`json_encode` and :phpfunction:`json_decode` functions. | ||
| This encoder requires the :doc:`Yaml Component </components/yaml>`. |
There was a problem hiding this comment.
Missing a version added note for this one.
wouterj
added a commit
that referenced
this pull request
Oct 13, 2017
…r (GuilhemN) This PR was submitted for the 3.2 branch but it was merged into the 3.3 branch instead (closes #7654). Discussion ---------- [Serializer] Document the CsvEncoder and the YamlEncoder Document the CsvEncoder and the YamlEncoder introduced in symfony/symfony#19197 and symfony/symfony#19326. Commits ------- 6944ea1 [Serializer] Document the CsvEncoder and the YamlEncoder
wouterj
added a commit
that referenced
this pull request
Oct 13, 2017
|
Thanks @GuilhemN for documenting these new serializers! Unfortunately, we've waited so long with merging this PR, we cannot merge it in 3.2 (as it's no longer maintained). So I've merged this in 3.3. I've also slightly changed the wording in b3f570e , because it didn't read nicely anymore now you've moved the json encoder above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the CsvEncoder and the YamlEncoder introduced in symfony/symfony#19197 and symfony/symfony#19326.