Skip to content

Update translation_domain.rst.inc #7845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Apr 27, 2017

No description provided.

@@ -1,7 +1,7 @@
translation_domain
~~~~~~~~~~~~~~~~~~

**type**: ``string`` **default**: ``messages``
**type**: ``string`` or ``false`` **default**: ``messages``
Copy link
Contributor

@HeahDude HeahDude Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Could you please also change the default which is actually null?

We should also note that null uses the parent form's value, messages is the default for the translator, that does not concern forms.

@enumag
Copy link
Contributor Author

enumag commented Apr 27, 2017

@HeahDude Should I rebase it and change the target branch to 2.7? Or do you have a way to do that on your side like with PRs to Symfony?

@javiereguiluz
Copy link
Member

Yes, we use the same tool to merge code and docs, so this should be doable by us.

@xabbuh
Copy link
Member

xabbuh commented Apr 28, 2017

Thank you @enumag.

xabbuh added a commit that referenced this pull request Apr 28, 2017
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7845).

Discussion
----------

Update translation_domain.rst.inc

Commits
-------

587cd7f Update translation_domain.rst.inc
xabbuh added a commit that referenced this pull request Apr 28, 2017
@xabbuh xabbuh closed this Apr 28, 2017
xabbuh added a commit that referenced this pull request May 3, 2017
* 2.7:
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Minor reword
  Update deployment.rst
  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()
  Better explain how to enable the validation component and its annotations
  Fix the link to ConEmu (it is now hosted on GitHub)
  Add annotation examples to match a route based on the host
  Minor reword to improve readability
  Minor reword and reformatting
  Add security stateless tip
  typo
xabbuh added a commit that referenced this pull request May 3, 2017
* 2.8:
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Fixed the form types of the buttons in the Form reference
  Minor reword
  Update deployment.rst
  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()
  Better explain how to enable the validation component and its annotations
  Fix the link to ConEmu (it is now hosted on GitHub)
  Add annotation examples to match a route based on the host
  Minor reword to improve readability
  Minor reword and reformatting
  Add security stateless tip
  typo
xabbuh added a commit that referenced this pull request May 3, 2017
* 3.2: (28 commits)
  [#7613] remove reference to AsseticBundle
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Fixed the form types of the buttons in the Form reference
  [#7832] use bin/console for Symfony 3.x
  Minor reword
  Update deployment.rst
  KernelTestCase::createKernel() is static, $this->createKernel() -> static::createKernel()
  Better explain how to enable the validation component and its annotations
  Fix the link to ConEmu (it is now hosted on GitHub)
  Add annotation examples to match a route based on the host
  Minor reword to improve readability
  Update service_container.rst
  Minor reword and reformatting
  ...
weaverryan added a commit that referenced this pull request May 5, 2017
* origin/master: (36 commits)
  Use the short Yaml syntax for service definition
  [#7613] remove reference to AsseticBundle
  minor #7613 Twig Extensions Reference minor brush-up (mpdude)
  Fix service locator declaration
  Minor reword
  Update Title in controller.rst
  Update scheme.rst
  Update requirements.rst
  [3.3] Document FQCN named controllers
  Document FQCN named controllers
  Use the short tag syntax
  [#7845] minor tweaks
  Update translation_domain.rst.inc
  Update page_creation.rst to correct hidden colon
  Update forms.rst
  Rewords
  Fixed the form types of the buttons in the Form reference
  [#7832] use bin/console for Symfony 3.x
  Minor reword
  Update deployment.rst
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants