Update page_creation.rst to correct hidden colon #7849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86-87: Italicized word covers top of colon Old: The method below the route - ``numberAction()`` - is called the *controller*: this is a function where *you* New: The method below the route - ``numberAction()`` - is called the *controller*. This is a function where *you* Instead of having the top of the colon bleed into the italicized word "controller" it makes visual sense to have the sentence end with a period and the next "This is a function..." begin with a capital letter since it can stand on its own as a sentence.
|
Thank you @tomgrandy. |
xabbuh
added a commit
that referenced
this pull request
Apr 28, 2017
This PR was submitted for the 3.2 branch but it was merged into the 2.7 branch instead (closes #7849). Discussion ---------- Update page_creation.rst to correct hidden colon 86-87: Italicized word covers top of colon Old: The method below the route - ``numberAction()`` - is called the *controller*: this is a function where *you* New: The method below the route - ``numberAction()`` - is called the *controller*. This is a function where *you* Instead of having the top of the colon bleed into the italicized word "controller" it makes visual sense to have the sentence end with a period and the next "This is a function..." begin with a capital letter since it can stand on its own as a sentence. Commits ------- c859e9d Update page_creation.rst to correct hidden colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
86-87: Italicized word covers top of colon
Old: The method below the route -
numberAction()- is calledthe controller: this is a function where you
New: The method below the route -
numberAction()- is calledthe controller. This is a function where you
Instead of having the top of the colon bleed into the italicized word "controller" it makes visual sense to have the sentence end with a period and the next "This is a function..." begin with a capital letter since it can stand on its own as a sentence.