Fix xml blocks #7915
Merged
Fix xml blocks #7915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
May 18, 2017
There was a problem hiding this comment.
@GuilhemN wow!! You must have spent a lot of time fixing all this. Thanks a lot! 🙇
And the mandatory comment when dealing with XML: I don't know how people can use this config format. It's beyond verbose ... it's ridiculously absurd.
|
Wow, thank you so much Guilhem! |
xabbuh
added a commit
that referenced
this pull request
May 18, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Fix xml blocks Commits ------- 2bf7529 Fix xml blocks
A bit 👼 but a proper search helped a lot :)
Completely agree... if I understood well, some IDEs have nice features motivating people to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.