[3.3] Finishing setTrustedProxies() changes & trusted_proxies removal #7952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
May 27, 2017
_build/redirection_map
Outdated
| @@ -336,3 +336,4 @@ | |||
| /components/dependency_injection/autowiring /service_container/autowiring | |||
| /event_dispatcher/class_extension /event_dispatcher | |||
| /security/target_path /security | |||
| /components/http_foundation/trusting_proxies /request/load_balancer_reverse_proxy | |||
xabbuh
reviewed
May 27, 2017
http_cache/varnish.rst
Outdated
| :ref:`How to Configure Symfony to Work behind a Load Balancer or a Reverse Proxy <request-untrust-header>`. | ||
| Remember to call the :ref:`Request::setTrustedProxies() <request-set-trusted-proxies>` | ||
| method in your front controller so that Varnish is seen as a trusted proxy | ||
| and the :ref:`X-Forwarded <varnish-x-forwarded-headers>` headers are used. |
xabbuh
reviewed
May 27, 2017
| @@ -183,44 +182,13 @@ named ``kernel.http_method_override``. | |||
| $request = Request::createFromGlobals(); | |||
| // ... | |||
|
|
|||
|
|
|||
xabbuh
reviewed
May 27, 2017
| xsi:schemaLocation="http://symfony.com/schema/dic/services | ||
| http://symfony.com/schema/dic/services/services-1.0.xsd | ||
| http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd"> | ||
| // tell Symfony about your revers proxy |
xabbuh
reviewed
May 27, 2017
|
|
||
| .. code-block:: php | ||
| // or, if your proxy instead uses the "Forwarded" header | ||
| // Request::HEADER_FORWARDED |
There was a problem hiding this comment.
we should also mention the HEADER_X_FORWARDED_AWS_ELB constant
|
👍 just some minor comments |
javiereguiluz
approved these changes
May 28, 2017
| http://symfony.com/schema/dic/symfony http://symfony.com/schema/dic/symfony/symfony-1.0.xsd"> | ||
| // tell Symfony about your revers proxy | ||
| Request::setTrustedProxies( | ||
| // the ip address (or range) of your proxy |
| using HTTPS. | ||
| The Request object has several ``Request::HEADER_*`` constants that control exactly | ||
| *which* headers from your reverse proxy are trusted. The argument is a bit field, | ||
| so you can also pass your own value (e.g. ``0b00110``). |
There was a problem hiding this comment.
I'm not sure about this part: ... so you can also pass your own value (e.g. 0b00110) Don't you think that'd be super confusing and hard to maintain?
weaverryan
added a commit
that referenced
this pull request
May 30, 2017
…roxies removal (JarJak, xabbuh, weaverryan) This PR was merged into the 3.3 branch. Discussion ---------- [3.3] Finishing setTrustedProxies() changes & trusted_proxies removal Finishes #7868 Commits ------- c7087bf tweaks thanks to review 45b419d Adding second argument to setTrustedProxies() and removing old information 2f83164 replace trusted_proxies reference 3632c08 replace diff code block with PHP code block 1825c83 Remove deprecated trusted_proxies config option df63034 Remove deprecated trusted_proxies config option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes #7868 and closes #7671