Minor reword for the intro of the Templating article #8018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 11, 2017
| handling each request that comes into a Symfony application. In reality, | ||
| the controller delegates most of the heavy work to other places so that | ||
| code can be tested and reused. When a controller needs to generate HTML, | ||
| As explained in :doc:`the previous article </controller>`, controllers are |
There was a problem hiding this comment.
IMO using something like "previous" here suggests that there is a sequence of the articles. But that's not really the case anymore.
There was a problem hiding this comment.
You are right ... except that in this case this article is indeed a part of a series. The Getting Started section groups the basic articles to learn Symfony and they are all linked. You can see that at the bottom of each article, which encourage s you to keep reading the next articles.
xabbuh
approved these changes
Jun 11, 2017
weaverryan
added a commit
that referenced
this pull request
Jun 13, 2017
…iereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Minor reword for the intro of the Templating article I don't like that the beginning of the article is *"As you know..."* ... because most of the people reading that will probably don't know 😄 I don't like either other minor things of that intro, so I propose this reword: ### Before  ### After  Commits ------- dde719d Minor reword for the intro of the Templating article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like that the beginning of the article is "As you know..." ... because most of the people reading that will probably don't know 😄
I don't like either other minor things of that intro, so I propose this reword:
Before
After