Skip to content

[Workflow] rearrange how workflow events are presented #8059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2017

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 18, 2017

see @weaverryan's suggestion in #8048 (comment)

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. i closed #8060 as its the same.

one question: is the naming for events in general "dispatch" or "fire"? i noticed i mixed the two terms, this PR changes all to "fire".

@xabbuh xabbuh force-pushed the pr-8048 branch 2 times, most recently from 5a568b5 to 6de5a10 Compare June 19, 2017 07:48
@xabbuh
Copy link
Member Author

xabbuh commented Jun 19, 2017

@dbu Thanks, I have made the whitespace changes here too.

@xabbuh
Copy link
Member Author

xabbuh commented Jun 19, 2017

Usually we use "dispatch". So I have made this consistent here and dropped "fired".

@xabbuh xabbuh merged commit f7405d2 into symfony:3.2 Jun 22, 2017
xabbuh added a commit that referenced this pull request Jun 22, 2017
…abbuh)

This PR was merged into the 3.2 branch.

Discussion
----------

[Workflow] rearrange how workflow events are presented

see @weaverryan's suggestion in #8048 (comment)

Commits
-------

f7405d2 rearrange how workflow events are presented
@xabbuh xabbuh deleted the pr-8048 branch June 22, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants