Skip to content

Added a note about container parameters and env vars #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

javiereguiluz
Copy link
Member

I know that the "note" mentions the Symfony Framework and this is the component article ... but this note should go to the article mentioned in #7386, which sadly doesn't exist yet.

@javiereguiluz
Copy link
Member Author

In this PR I also propose to highlight the .env files with shell instead of bash. The reason is that bash is wrapped with a fake console illustration, and that's wrong in this case.

Before

before

After

after

@fabpot
Copy link
Member

fabpot commented Jul 17, 2017

I don't understand this change. What's the solution? Just saying it does not work does not help our users. I would really prefer to fix this in Symfony instead. /cc @nicolas-grekas

@javiereguiluz
Copy link
Member Author

There's been a misunderstandig then. Reading this note I thought you didn't want to add this feature to Dotenv:

PHP has a lot of different implementations of this "pattern". This
implementation's goal is to replicate what source .env would do. It
tries to be as similar as possible with the standard shell's behavior (so
no value validation for instance).

@fabpot
Copy link
Member

fabpot commented Jul 17, 2017

This talks about validation. Here, we are talking about container parameter replacement, which can work for both regular env vars and ones coming from a .env file.

@nicolas-grekas
Copy link
Member

This doesn't relate to Dotenv specifically to me: parameters are not resolved into environment vars, wherever it comes from. Or did I miss something?

@fabpot
Copy link
Member

fabpot commented Jul 17, 2017

Indeed, the question is "do we want to resolve parameters for all env vars"?

@fabpot
Copy link
Member

fabpot commented Sep 11, 2017

I'm closing this PR as this can be fixed thanks to symfony/symfony#23901

@fabpot fabpot closed this Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants